Parse scalars for no-cache queries - #13372
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ffe0afb70fee214200b7a8f5 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
🦋 Changeset detectedLatest commit: 734c0c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
1 participant
I'm putting this up as a topic of discussion. It handles parsing custom scalars for
no-cachequeries, but comes at the cost that it runs on every response for every query. We would likely need an additional API from the cache that tells us when scalars are configured so that we can skip the work when a user isn't using scalars.If we choose not to go this route, we'll need at least a TypeScript solution in place that can handle choosing the serialized types for custom scalar fields, that way users can handle the parsing logic in their apps as needed. This requires additional work in codegen to make work.
Note
This is an experiment and might not make it into the 4.3 release. We are still evaluating whether this makes sense.